Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(aio): make e2e tests less flakey (and use correct typings) #20117

Closed
wants to merge 3 commits into from
Closed

test(aio): make e2e tests less flakey (and use correct typings) #20117

wants to merge 3 commits into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Nov 2, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@gkalpak gkalpak added comp: aio area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 2, 2017
@mary-poppins
Copy link

You can preview 1baa57f at https://pr20117-1baa57f.ngbuilds.io/.

@petebacondarwin petebacondarwin added this to REVIEW in docs-infra Nov 3, 2017
@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 3, 2017
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra Nov 3, 2017
@gkalpak gkalpak mentioned this pull request Nov 3, 2017
Closed
@vicb vicb closed this in a99eb16 Nov 3, 2017
vicb pushed a commit that referenced this pull request Nov 3, 2017
@gkalpak @vicb
test(aio): make e2e tests less flakey
e4cd3b0 
closes #20117
@gkalpak gkalpak deleted the test-aio-unflake branch November 3, 2017 19:03
@petebacondarwin
Copy link
Member

:fingers-crossed:

@petebacondarwin petebacondarwin removed this from MERGE in docs-infra Nov 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gkalpak @mary-poppins @petebacondarwin @googlebot